[PATCH] D64376: [MBP] Avoid tail duplication if it can't bring benefit

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 08:50:13 PDT 2019


davidxl added inline comments.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:1069
 /// into all of its unplaced, unfiltered predecessors, that are not BB.
 bool MachineBlockPlacement::canTailDuplicateUnplacedPreds(
     const MachineBasicBlock *BB, MachineBasicBlock *Succ,
----------------
Can the code be restructured here so that it  picks and returns  the top two most profittable predecessors and perform tail dup into them?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64376/new/

https://reviews.llvm.org/D64376





More information about the llvm-commits mailing list