[PATCH] D67158: [ARM] Add IR intrinsics for a sample of MVE instructions.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 04:54:20 PDT 2019


simon_tatham marked 8 inline comments as done.
simon_tatham added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsARM.td:816
+
+def int_arm_mve_fltnarrow: Intrinsic<[llvm_v8f16_ty],
+   [llvm_v8f16_ty, llvm_v4f32_ty, llvm_i32_ty], [IntrNoMem]>;
----------------
dmgreen wrote:
> Any reason this is called fltnarrow? As opposed to something closer to the name of the instruction?
Not any particularly good reason. I had the vague idea of naming things after their functionality as long as it didn't turn the name into a giant essay (there's probably no hope for `vrmlaldavhax`), on the vague principle that that might make them easier to find if anyone later goes looking for platform-specific intrinsics that could be pulled out into standard IR representations. But it's not something I'm strongly committed to, just a harebrained idea I thought I'd throw out there to see if anyone had opinions about it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67158/new/

https://reviews.llvm.org/D67158





More information about the llvm-commits mailing list