[PATCH] D67424: [Support] Add overload writeFileAtomically(std::function Writer)

Dmitri Gribenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 03:15:51 PDT 2019


gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/tools/lldb-server/lldb-platform.cpp:24
 
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/FileUtilities.h"
----------------
Move the new header here, to group with the rest?


================
Comment at: llvm/lib/Support/FileUtilities.cpp:332
+
+char llvm::AtomicFileWriteError::ID;
----------------
Please add a newline.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67424/new/

https://reviews.llvm.org/D67424





More information about the llvm-commits mailing list