[PATCH] D67398: [DebugInfo] LiveDebugValues: Move DBG_VALUE creation into VarLoc class

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

I think that the problem described within the D67393 <https://reviews.llvm.org/D67393> imposes a solution with introducing something like `DBG_LOC`, as @aprantl already suggested.



================
Comment at: lib/CodeGen/LiveDebugValues.cpp:262
+      VarLoc VL(MI, LS);
+      VL.Kind = EntryValueKind;
+      VL.Expr = EntryExpr;
----------------
Is this redundant, since we already set the Kind within the `VarLoc`'s constructor?


================
Comment at: test/DebugInfo/MIR/X86/live-debug-values-restore.mir:205
   !328 = !DILocation(line: 109, column: 3, scope: !307)
+  !401 = !DIBasicType(name: "looong int", size: 64, encoding: DW_ATE_signed)
+  !407 = distinct !DISubprogram(name: "j", scope: !0, file: !1, line: 105, type: !8, scopeLine: 105, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !412)
----------------
nit: Please make this in order.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67398/new/

https://reviews.llvm.org/D67398