[llvm] r371573 - [MemorySSA] MemorySSA should not model debuginfo, and need not update it.

Alina Sbirlea via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 16:36:43 PDT 2019


Author: asbirlea
Date: Tue Sep 10 16:36:43 2019
New Revision: 371573

URL: http://llvm.org/viewvc/llvm-project?rev=371573&view=rev
Log:
[MemorySSA] MemorySSA should not model debuginfo, and need not update it.

Reverts the change in r371084, but keeps the test.
After r371565, debuginfo cannot be modelled in MemorySSA, even with a
non-standard AA pipeline.

Modified:
    llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp

Modified: llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp?rev=371573&r1=371572&r2=371573&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp Tue Sep 10 16:36:43 2019
@@ -250,11 +250,8 @@ bool llvm::MergeBlockIntoPredecessor(Bas
       llvm::findDbgValues(DbgValues, Incoming);
       for (auto &DVI : DbgValues) {
         auto R = DbgValueSet.insert({DVI->getVariable(), DVI->getExpression()});
-        if (!R.second) {
-          if (MSSAU)
-            MSSAU->removeMemoryAccess(DVI);
+        if (!R.second)
           DVI->eraseFromParent();
-        }
       }
     }
   }




More information about the llvm-commits mailing list