[PATCH] D67305: [AliasSetTracker] Update AAInfo check.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 16:25:42 PDT 2019


hfinkel added inline comments.


================
Comment at: include/llvm/Analysis/AliasSetTracker.h:87
         // We don't have a AAInfo yet. Set it to NewAAInfo.
         AAInfo = NewAAInfo;
+      else if (AAInfo.TBAA != NewAAInfo.TBAA ||
----------------
asbirlea wrote:
> hfinkel wrote:
> > Given what we know about the code below, is this sound?
> Would you mind elaborating?
If an AAMD field going from non-null to null requires a merge, why does going from null to non-null not require a merge?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67305/new/

https://reviews.llvm.org/D67305





More information about the llvm-commits mailing list