[PATCH] D67363: [BreakFalseDeps] ignore function with minsize attribute
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 10 13:07:12 PDT 2019
spatel added a comment.
In D67363#1664788 <https://reviews.llvm.org/D67363#1664788>, @craig.topper wrote:
> I believe this test case compiled with avx needs this pass.
>
> define double @minsize(double %x, double %y) minsize {
>
> %t6 = tail call fast double @llvm.sqrt.f64(double %y)
> %t= fadd fast double %t6, %y
> ret double %t6
>
> }
> declare double @llvm.sqrt.f64(double)
Thanks! I didn't understand where that happened - it's in here (and no existing regression tests appear to capture that).
So yes, to limit this pass, we need to use a slightly finer check to distinguish between transforms that are only changing registers vs. adding instructions.
Added more tests with rL371528 <https://reviews.llvm.org/rL371528> and rL371551 <https://reviews.llvm.org/rL371551>.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67363/new/
https://reviews.llvm.org/D67363
More information about the llvm-commits
mailing list