[PATCH] D67301: [LLD] Use the unified llvm demangle frontend function. NFC.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 12:24:19 PDT 2019


mstorsjo added a comment.

In D67301#1664700 <https://reviews.llvm.org/D67301#1664700>, @MaskRay wrote:

> This change is not NFC. This will cause every port of LLD to demangle more names than which were allowed before.
>
> I hope at least for ELF, you can keep the `"_Z"` prefix check. It doesn't need the ObjC `"___Z"` extension.


Ok, let's keep it strict then.

I'd suggest adding a parameter to the llvm global demangle convenience function, to decide between whether it should require a strict prefix (only `_Z`) or if 1-4 underscores are allowed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67301/new/

https://reviews.llvm.org/D67301





More information about the llvm-commits mailing list