[PATCH] D67377: [PGO][PGSO] ProfileSummary changes.

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

I don't think we should use 'PGSO' in the profile summary class. Instead, we should differentiate it from 'hot'   with other categories like VeryHot,  LukeWarm etc ...



================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:103
+  /// PGSO.
+  bool pgsoHasHugeWorkingSetSize();
   /// Returns true if \p F has hot function entry.
----------------
Why can't PGSO huge working set size be unified with the  regular one?


================
Comment at: llvm/lib/Analysis/ProfileSummaryInfo.cpp:60
 
+static cl::opt<int> PgsoCutoffInstrProf(
+    "pgso-cutoff-instr-prof", cl::Hidden, cl::init(250000), cl::ZeroOrMore,
----------------
Call it ProfileSummaryCutoffInstVeryHot


================
Comment at: llvm/lib/Analysis/ProfileSummaryInfo.cpp:66
+
+static cl::opt<int> PgsoCutoffSampleProf(
+    "pgso-cutoff-sample-prof", cl::Hidden, cl::init(800000), cl::ZeroOrMore,
----------------
ProfileSummaryCutoffSampleVeryHot


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67377/new/

https://reviews.llvm.org/D67377