[PATCH] D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 09:59:55 PDT 2019


arsenm added a comment.

Can you also add a MIR test for this? Also testing the 16-bit case would be nice



================
Comment at: lib/Target/AMDGPU/SIFoldOperands.cpp:512-514
+      if (UseOpc != AMDGPU::V_MAC_F32_e64 &&
+          UseOpc != AMDGPU::V_MAC_F16_e64 &&
+          UseOpc != AMDGPU::V_FMAC_F32_e64)
----------------
Can you fold this opcode list into a canFoldTiedSrcOp (or something similar) predicate function


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66666/new/

https://reviews.llvm.org/D66666





More information about the llvm-commits mailing list