[PATCH] D67120: [PGO] Profile guided code size optimization (continued).

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 09:53:23 PDT 2019


yamauchi added a comment.

Split the PSI changes into https://reviews.llvm.org/D67377.

It looks like the TTI part can't be separated due to dependencies and would pull in the whole thing:

The TTI files (TargetTransformInfo.h, TargetTransformInfoImpl.h, BasicTTIImpl.h, TargetTransformInfo.cpp) would pull in TargetLowering.h for the isSuitableForJumpTable change, which then would pull in SizeOpts.h/cpp for the llvm::shouldOptimizeForSize change. In addition, TargetLowering.h would also pull in SwitchLoweringUtils.cpp for the isSuitableForJumpTable change, which would pull in isSuitableForJumpTable.h for findJumpTables change, which would pull in SelectionDAGBuilder.cpp and IRTranslator.cpp for the findJumpTables changes,...etc.

Did you think of a different way to split the TTI part?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67120/new/

https://reviews.llvm.org/D67120





More information about the llvm-commits mailing list