[PATCH] D66160: [llvm-nm] Add tapi file support

Juergen Ributzka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 09:30:59 PDT 2019


ributzka added a comment.

The motivation to add this to llvm-nm, is to get the same functionally back that we lost with adding TBD files. Using it for testing is a nice side benefit.



================
Comment at: llvm/lib/TextAPI/MachO/Architecture.cpp:73
+bool is64Bit(Architecture Arch) {
+  return ArchitectureSet({AK_arm64, AK_x86_64, AK_x86_64h}).has(Arch);
+}
----------------
I would prefer if we added this information to Architecture.def and then use it here. That way the code will not get out-of-sync when someone adds a new architecture slice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66160/new/

https://reviews.llvm.org/D66160





More information about the llvm-commits mailing list