[PATCH] D67363: [BreakFalseDeps] ignore function with minsize attribute

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 08:04:40 PDT 2019


spatel added a comment.

In D67363#1664689 <https://reviews.llvm.org/D67363#1664689>, @craig.topper wrote:

> For VEX instructions don’t we just use the other input register to break the dependency without adding an instruction?


That sounds right, but it's not controlled by this pass. That's part of memory op folding?
If I'm seeing it correctly, that's already more aggressively optimizing for size than what we're doing here:

  // Avoid partial and undef register update stalls unless optimizing for size.
  if (!MF.getFunction().hasOptSize() &&
      (hasPartialRegUpdate(MI.getOpcode(), Subtarget, /*ForLoadFold*/true) ||
       shouldPreventUndefRegUpdateMemFold(MF, MI)))
    return nullptr;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67363/new/

https://reviews.llvm.org/D67363





More information about the llvm-commits mailing list