[PATCH] D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278).

[Xing via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 219524.
Higuoxing added a comment.

Thank you @grimar, @jhenderson and @Maskray .

I googled about stackmaps, and it's possible to have multiple entries of stackmap. Currently, llvm-readobj assumes there is only one entry per file. See this thread: https://bugs.llvm.org/show_bug.cgi?id=38277

I've tested on my machine, using trunk version of clang. If both object files have one stackmap section, linker just concatenates them into one section. So, this is a bug, right? I would like to hard-code the offset as 0x0 in this patch, and improve this behavior in the future. Do you happy with my opinion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67328/new/

https://reviews.llvm.org/D67328

Files:
  llvm/include/llvm/Object/StackMapParser.h
  llvm/test/tools/llvm-readobj/elf-stackmap-unsupported-version-2.test
  llvm/tools/llvm-readobj/COFFDumper.cpp
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/llvm-readobj/MachODumper.cpp
  llvm/tools/llvm-readobj/StackMapPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67328.219524.patch
Type: text/x-patch
Size: 5364 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190910/b4a29998/attachment.bin>