[PATCH] D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp

[Dmitri Gribenko via Phabricator via llvm-commits]

gribozavr added a comment.

Thank you for the fix! I can confirm that the new patch does not break this test in my environment.

I'm not an expert in this part of the backend, however, I wanted to ask to add more tests to the patch, both positive and negative. The logic in the code is quite complex, it has lots of branches (so there are many possibilities for things to go wrong), but testing is extremely light. The patch is only updating existing tests in three places -- which to me looks more like a happy coincidence (that LLVM already includes tests that happen to trigger the new behavior) than intentional testing. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65267/new/

https://reviews.llvm.org/D65267