[PATCH] D45375: [ELF] - Introduce synthetic file for linker script symbols.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 04:14:37 PDT 2019


MaskRay added a comment.
Herald added subscribers: dexonsmith, steven_wu.

I recently came across the `<internal>` issue, and was just reminded of the presence of the patch. I am in favor of this change.

Currently we had 7 states: `nullptr, ObjKind, SharedKind, LazyObjKind, ArchiveKind, BitcodeKind, BinaryKind`.
With this change, we still have 7: `SyntheticKind, ObjKind, SharedKind, LazyObjKind, ArchiveKind, BitcodeKind, BinaryKind`.

A nice property is that `InputSectionBase::file` and `Symbol::file` will never be null.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45375/new/

https://reviews.llvm.org/D45375





More information about the llvm-commits mailing list