[PATCH] D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 03:53:23 PDT 2019


On Tue, Sep 10, 2019 at 1:51 PM Clément Courbet via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> I must admit that I only did `ninja check-llvm`, given that I was only touching the backend. It feels weird that I can break clang tests with such changes, is that really intended ?
That test is broken, clang codegen tests should not be dependent on
llvm middle-end behavior.


> On Tue, Sep 10, 2019 at 12:39 PM Dmitri Gribenko via Phabricator <reviews at reviews.llvm.org> wrote:
>>
>> gribozavr added a comment.
>>
>> Sorry, this change broke the buildbots: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/17395, I reverted it (r371507). Please ensure that you run `ninja check-all` before committing.
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D60318/new/
>>
>> https://reviews.llvm.org/D60318
>>
>>
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list