[PATCH] D52812: Change the warning message for -warn-ifunc-textrel.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 03:05:42 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:991
+           "consider rewriting code without ifunc or link your program without "
+           "`-z text`. Use `-no-warn-ifunc-textrel` to disable this warning." +
            getLocation(Sec, Sym, Offset));
----------------
emaste wrote:
> I'm not sure about advice to link without `-z text` - that's the default, and so linking with or without it should have the same effect, disallowing text relocations?
I wonder if this option is still needed...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52812/new/

https://reviews.llvm.org/D52812





More information about the llvm-commits mailing list