[PATCH] D67388: Add a feature to dump dependency graph.

Tue Sep 10 02:22:56 PDT 2019

ruiu added a comment.

In D67388#1664387 <https://reviews.llvm.org/D67388#1664387>, @grimar wrote:

> I looked at the sample provided and I think that if I was a new user, I'd find not clear what is "<internal>" probably.
>  What about including something like "<internal> is usually a symbol defined by linker" line to the header?
>
> Also I am not sure what is situation now, but before we used to report "<internal>" for linker script defined symbols
>  in our messages sometimes. Would be nice to have a test for that case.

"<internal>" does not represent a symbol but a file. Ideally we should give more meaningful name for each virtual file, but I think that's beyond the scope of this patch.

> About printing "-": I am not sure how much it is usefull? Actually it was a bit confusing to see it for me at first. I think if file
>  is provided by command line it is enough to print "<commandline> <filename>" probably.

I can remove "-" from the "<commandline>" lines.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67388/new/

https://reviews.llvm.org/D67388