[PATCH] D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278).

[Xing via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 219473.
Higuoxing added a comment.

Addressed @grimar 's comments

- Remove excessive indentions.
- Remove some unused fields (Flags, AddressAlign).
- Minimize contents of stack map section. (Only keep version in header field).
- Change variable name to upper case.
- Use `reportWarning`.

Addressed @jhenderson 's comments

- Add comments on top of test file.
- Use double-dash option
- Change warning hint.
- There are only one entry for `Header` which contains version number in stack map section, See: https://llvm.org/docs/StackMaps.html#stack-map-format (Is offset still needed?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67328/new/

https://reviews.llvm.org/D67328

Files:
  llvm/include/llvm/Object/StackMapParser.h
  llvm/test/tools/llvm-readobj/elf-stackmap-version2.test
  llvm/tools/llvm-readobj/COFFDumper.cpp
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/llvm-readobj/MachODumper.cpp
  llvm/tools/llvm-readobj/StackMapPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67328.219473.patch
Type: text/x-patch
Size: 5503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190910/b1aad457/attachment.bin>