[PATCH] D67121: [TargetLowering] Make allowsMemoryAccess methode virtual.

Mon Sep 9 09:45:10 PDT 2019

arsenm added a comment.

In D67121#1656980 <https://reviews.llvm.org/D67121#1656980>, @jmolloy wrote:

> > On the other hand, I don't really want to spend much time thinking about how to make SelectionDAG better at this point.
>
> I agree, that's kind of my worry with opening this pandora's box. Changing hooks in SDAG and maintaining performance parity is very hard, and we have a longer term solution in Global Isel.
>
> Given that, and given the NFC-ness of this patch, are you happy for it to go in?

I'm not happy about it but not too opposed. I'd like someone else's opinion

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67121/new/

https://reviews.llvm.org/D67121