[PATCH] D67193: [UBSan] Do not overwrite the default print_summary sanitizer option.

[Max Moroz via Phabricator via llvm-commits]

Dor1s added a comment.

Removed @kcc as a "blocking" reviewer, since we've discussed this offline last week. I'll check with @vitalybuka regarding potential breakages and also ping @samsonov. Other than that, should be good to go.

@hctim regarding your question, I think the intention is that the summary line would end with the function name and/or its offset. That seems to work fine with e.g. ASan, but somehow appends an empty name for UBSan. Anyhow, it's better to be fixed in a separate change, as either of those might be reverted and landing two things together would just increase the chances.

See `RenderFrame` in `compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.cpp`:

  // Function name and offset, if file is unknown.
  if (info.function) {
    buffer->append("in %s",
                   DemangleFunctionName(
                     StripFunctionName(info.function, strip_func_prefix)));
    if (!info.file && info.function_offset != AddressInfo::kUnknown)
      buffer->append("+0x%zx", info.function_offset);
  }


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67193/new/

https://reviews.llvm.org/D67193