[PATCH] D66936: [DFAPacketizer] Track resources for packetized instructions

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 9 06:16:49 PDT 2019


I've reapplied this as rL371399; please do revert (or email and I will
revert) if it breaks you again. I'll be keeping an eye on the buildbots too.

Cheers,

James

On Mon, 9 Sep 2019 at 13:49, James Molloy <jmolloy at google.com> wrote:

> No worries, thanks for taking affirmative action!
>
> I have a candidate patch that reduces the compile time on GCC and Clang by
> a large factor. I'm expecting/hoping that the compiler resource usage on VS
> would also decrease a commensurate amount.
>
> Would you prefer to patch it in or have me roll forward and you roll back
> again if the same issue occurs? (do we have a buildbot that fails? I
> checked my bot mail afterwards but couldn't see anything useful).
>
> James
>
> On Mon, 9 Sep 2019 at 13:40, Simon Pilgrim via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> RKSimon added a comment.
>>
>> In D66936#1662832 <https://reviews.llvm.org/D66936#1662832>, @RKSimon
>> wrote:
>>
>> > @jmolloy This is causing "compiler is out of heap space" errors on my
>> VS2017 and VS2019 all targets builds:
>> >
>> >   e:\llvm\ninja17\lib\target\hexagon\hexagongendfapacketizer.inc(4892)
>> : fatal error C1002: compiler is out of heap space in pass 2
>> >
>>
>>
>> I'm sorry but I had to revert this at rL371393 <
>> https://reviews.llvm.org/rL371393>, I didn't get very far in triaging
>> what is the causing the issue but if you have a candidate patch I'm happy
>> to test it.
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D66936/new/
>>
>> https://reviews.llvm.org/D66936
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190909/562c022a/attachment.html>


More information about the llvm-commits mailing list