[PATCH] D62989: [Unroll] Do NOT unroll a loop with small runtime upperbound

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 9 05:57:24 PDT 2019


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/Scalar/LoopUnrollAndJamPass.cpp:168
   bool ExplicitUnroll = computeUnrollCount(
-      L, TTI, DT, LI, SE, EphValues, ORE, OuterTripCount, MaxTripCount,
+      L, TTI, DT, LI, SE, EphValues, ORE, OuterTripCount, MaxTripCount, false,
       OuterTripMultiple, OuterLoopSize, UP, UseUpperBound);
----------------
Can you please add a comment here next to `false` so that it is clear what this is

  /*MaxOrZero*/ false



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62989/new/

https://reviews.llvm.org/D62989





More information about the llvm-commits mailing list