[PATCH] D66413: [ARM} Add support for MVE vmaxv

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 9 03:11:08 PDT 2019


samtebbs marked an inline comment as done.
samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1064
     return false;
+  case Instruction::ICmp:
   case Instruction::Add:
----------------
samparker wrote:
> Is this actually needed for codegen?
It is, as otherwise the smax and umax vector reductions aren't generated and can't be selected on.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66413/new/

https://reviews.llvm.org/D66413





More information about the llvm-commits mailing list