[PATCH] D67340: [Object] Implement relocation resolver for COFF ARM/ARM64

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.
Herald added a subscriber: ormris.


================
Comment at: lib/Object/RelocationResolver.cpp:443
+  case COFF::IMAGE_REL_ARM_ADDR32:
+    return (S + A) & 0xFFFFFFFF;
+  default:
----------------
Is it OK to silently wrap-around an overflowed value? I wonder if we should report an error.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67340/new/

https://reviews.llvm.org/D67340