[PATCH] D66976: Small update to Expected<StringRef>

Sat Sep 7 00:53:03 PDT 2019

grimar added a comment.

In D66976#1661686 <https://reviews.llvm.org/D66976#1661686>, @dblaikie wrote:

> (also, can be helpful in the future to note that a patch is fixing a buildbot failure/existing test suite failure - otherwise it's harder to tell if it's missing test coverage)

Sure. But in this case this patch was landed first, since it fixed an obvious misspeling. (i.e. there was bo BB failture or existent test).
Writing the test was a bit complicated since it requred one more patch for yaml2obj
to produce the binary broken in a specific way. So it was landed without the test which was added in rL370669 <https://reviews.llvm.org/rL370669> after rL370633 <https://reviews.llvm.org/rL370633> (patch for yaml2obj) was landed.
And the description for rL370669 <https://reviews.llvm.org/rL370669> contans the information about what it is for :)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66976/new/

https://reviews.llvm.org/D66976