[PATCH] D67105: [TargetLowering] Fix another potential FPE in expandFP_TO_UINT

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 12:10:35 PDT 2019


kpn added a comment.
Herald added a subscriber: ychen.

Well, I like it. The problem is solved, the pseudocode is I find a little easier to read, and the System/Z instruction sequence looks like a sideways move performance-wise.

An outsider's view is that the X86 instructions look worse, but in the strict case I think correctness should win. If that strictness isn't required then targets can still use the old non-strict sequence. I am surprised the X86 instruction sequences are that different.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67105/new/

https://reviews.llvm.org/D67105





More information about the llvm-commits mailing list