[PATCH] D67203: [IfConversion] Fix diamond conversion with unanalyzable branches.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 01:07:47 PDT 2019


hans added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/IfConversion.cpp:1764
   DI1 = MBB1.end();
+  while (DI1 != MBB1.begin()) {
+    MachineBasicBlock::iterator Prev = std::prev(DI1);
----------------
The previous code also decremented BBI1->NonPredSize. Do we not need to do that anymore?

(I don't know this code, just driving by.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67203/new/

https://reviews.llvm.org/D67203





More information about the llvm-commits mailing list