[PATCH] D67071: [CodeGen] Handle SMULFIXSAT with scale zero in TargetLowering::expandFixedPointMul

Thu Sep 5 15:20:17 PDT 2019

bjope added a comment.

In D67071#1659854 <https://reviews.llvm.org/D67071#1659854>, @RKSimon wrote:

> Worth adding a vector test ?

VectorLegalizer::Expand is still doing unroll instead of calling ExpandFixedPointMul for SMULFIXSAT. I do not think that we currently ever get here with a vector type (with saturation). The only point with adding a vector test would be to have one for completion, in case we want to change that behavior in the future. So I don't think that it is relevant for the bugfix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67071/new/

https://reviews.llvm.org/D67071