[PATCH] D67078: [llvm-readelf] - Allow dumping the dynamic symbols when there is no program headers.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 02:38:10 PDT 2019


grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/dyn-symbols.test:274-275
+        Value: 0
+  - Name: .dynsym
+    Type: SHT_DYNSYM
+  - Name: .mydynsym
----------------
jhenderson wrote:
> Won't this be implicitly generated?
Yes, but this is probably not so obvious here? It probably can raise questions,
like: "will the default SHT_DYNSYM be generated if we already have one in the YAML?".
Having 2 described makes this test case pretty straightforward.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67078/new/

https://reviews.llvm.org/D67078





More information about the llvm-commits mailing list