[PATCH] D66967: [Attributor] ValueSimplify Abstract Attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

We should make sure we track statistics properly, e.g., only if the simplified value is different from the original value we track sth.
This would be automatic if simplified value = original value will imply an "invalid state".



================
Comment at: llvm/test/Transforms/FunctionAttrs/value-simplify.ll:117
+  ; CHECK: tail call void @use(i32 %select-not-same-undef)
+  tail call void @use(i32 %select-not-same-undef)
+
----------------
This should arguably be
  `; CHECK: tail call void @use(i32 %phi-not-same)`
The pessimistic fixpoint should probably not revert to `nullptr` and cause a cascading failure but instead just go back to the original value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66967/new/

https://reviews.llvm.org/D66967