[PATCH] D67152: Align output segments correctly

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 05:30:04 PDT 2019


peter.smith added inline comments.


================
Comment at: lld/ELF/Writer.cpp:2276
+    uint64_t alignment =
+        std::max<uint64_t>(os->ptLoad->p_align, config->maxPageSize);
     return alignTo(off, alignment, os->addr);
----------------
Just a thought, could this be reduced to os->ptLoad->p_align? I think config->maxPageSize would already be reflected in ptLoad->p_align. I'll have a check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67152/new/

https://reviews.llvm.org/D67152





More information about the llvm-commits mailing list