[PATCH] D63877: Avoid infinite loop with asan interception

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 00:30:52 PDT 2019


Hahnfeld added a comment.

In D63877#1656860 <https://reviews.llvm.org/D63877#1656860>, @serge-sans-paille wrote:

> > Is that summary correct?
>
> It is :-)


Then my conclusion would be that the test incorrectly assumes asan to be linked against a C++ stdlib. Sure, we could restrict the test to the case where this assumption holds (not via `cxxabi`, maybe by introducing another feature). But I wonder if there are better solutions that don't lose coverage on my kind of configurations (and possibly others like @uweigand if we can't detect them during configuration time and don't want failing tests). Where exactly does `__cxa_throw` need to be defined in order to trigger the infinite loop in the old code?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63877/new/

https://reviews.llvm.org/D63877





More information about the llvm-commits mailing list