[PATCH] D66902: [PowerPC] Implementing overflow version for XO-Form instructions

[Amy Kwan via Phabricator via llvm-commits]

amyk accepted this revision.
amyk added a comment.
This revision is now accepted and ready to land.

I think this overall LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:1028
 
+//Multiclass for instructions which have a record overflow form as well
+//as a record form but no carry (i.e. mulld, mulldo, subf, subfo, etc.)
----------------
Space after `//`. 


================
Comment at: llvm/test/MC/PowerPC/ppc64-encoding.s:342
             add. 2, 3, 4
-# FIXME:    addo 2, 3, 4
-# FIXME:    addo. 2, 3, 4
+# CHECK-BE: addo 2, 3, 4		    # encoding: [0x7c,0x43,0x26,0x14]
+# CHECK-LE: addo 2, 3, 4		    # encoding: [0x14,0x26,0x43,0x7c]
----------------
I would say it is better to make the `# encoding` lines in line with the others, for consistency. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66902/new/

https://reviews.llvm.org/D66902