[PATCH] D67094: [llvm-readelf] - Print unknown st_other value if present in GNU output.

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, rupprecht.
Herald added a subscriber: seiya.

This is a fix for https://bugs.llvm.org/show_bug.cgi?id=40785.

llvm-readelf does not print the st_value of the symbol when
st_value has any non-visibility bits set.

This patch:

- Aligns "Ndx" row for the default and a new cases.

(it was 1 space character off for the case when "PROTECTED" visibility was printed)

- Prints "[<other>: 0x??]" for symbols which has an additional st_other bits set.

In compare with GNU, this logic is simpler and seems more consistent.
The details about the known differences were listed in the comments on a bug page.


https://reviews.llvm.org/D67094

Files:
  test/tools/llvm-readobj/elf-symbol-visibility.test
  tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67094.218440.patch
Type: text/x-patch
Size: 10342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190903/8c90f8ae/attachment.bin>