[PATCH] D66938: [ARM][MVE] Decoding of VMSR doesn't diagnose some unpredictable encodings

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 01:46:57 PDT 2019


ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.

LGTM with one style nit.



================
Comment at: lib/Target/ARM/ARMInstrVFP.td:2412
   let Inst{7}     = 0;
+  let Inst{6-5}   = 0b00;
   let Inst{4}     = 1;
----------------
These lines could be collapsed together:

  let Inst{11-0} = 0b101000010000;


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66938/new/

https://reviews.llvm.org/D66938





More information about the llvm-commits mailing list