[PATCH] D67039: [ELF] Add a spell corrector for "undefined symbol" diagnostics

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 1 21:46:56 PDT 2019


ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:736
 
+  if (spellCorrector) {
+    // Build a map of local defined symbols.
----------------
Can you factor out the new code into a new function and then add a function comment as to what this is?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67039/new/

https://reviews.llvm.org/D67039





More information about the llvm-commits mailing list