[PATCH] D37648: [SLPVectorizer] Fix PR21780 Expansion of 256 bit vector loads fails to fold into shuffles

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 1 13:58:46 PDT 2019


lebedev.ri added a comment.

In D37648#1654027 <https://reviews.llvm.org/D37648#1654027>, @dtemirbulatov wrote:

> In D37648#1653860 <https://reviews.llvm.org/D37648#1653860>, @RKSimon wrote:
>
> > Abandon this? I think this is being handled by the (WIP) Attributor work to support dereference
>
>
> no, I think I can rebase the change.


I suspect @RKSimon is might be right here, it may be better to redesign the feature with nowadays best practices in mind (attributor).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D37648/new/

https://reviews.llvm.org/D37648





More information about the llvm-commits mailing list