[PATCH] D47927: [TargetLowering] Simplify expansion of S{ADD,SUB}O

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 06:02:27 PDT 2019


nikic added a comment.

IMHO this should land as-is, and setcc folds can be implemented additionally if there are other places where they would be useful. My rationale would be that it is better to directly perform a simpler lowering than a complex lowering that then gets optimized. (Basically: If you can reduce the size of the implementing code //and// get a better result, then I think we should always be doing that.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47927/new/

https://reviews.llvm.org/D47927





More information about the llvm-commits mailing list