[PATCH] D66725: [DAGCombiner][TargetLowering] Target hook for FCOPYSIGN arg cast folding

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 16:55:59 PDT 2019


luismarques marked an inline comment as done.
luismarques added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2590
+  virtual bool canCopySign(EVT ValueTy, EVT SignTy) const {
+    return isOperationExpand(ISD::FCOPYSIGN, ValueTy) || ValueTy == SignTy;
+  }
----------------
luismarques wrote:
> lenary wrote:
> > Which targets use this default and not `SignTy != i128`, beyond RISC-V and WebAssembly?
> AArch64 overrides the hook but accepts all types, including `f128`. In-tree targets that keep the default implementation in this patch are ARC, AVR, BPF, Lanai, MSP430, NVPTX, Sparc, RISCV and WebAssembly.
...and XCore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66725/new/

https://reviews.llvm.org/D66725





More information about the llvm-commits mailing list