[PATCH] D66766: [SampleFDO] Add symbol whitelist section to discriminate function being cold versus function being newly added

[Wei Mi via Phabricator via llvm-commits]

wmi marked an inline comment as done.
wmi added a comment.

In D66766#1651328 <https://reviews.llvm.org/D66766#1651328>, @davidxl wrote:

> Suggesting on the naming: instead of using SymbolWhiteList, use 'ProfileSymbolList', or just 'SymbolList'.  Otherwise the patch looks ok


Choose to use ProfileSymbolList.



================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:1734
   // If ProfileSampleAccurate is true or F has profile-sample-accurate
-  // attribute, initialize the entry count to 0 so callsites or functions
-  // unsampled will be treated as cold.
+  // attribute, and if there is no symbol whitelist read in, initialize all
+  // the function entry counts to 0; if there is symbol whitelist, only
----------------
davidxl wrote:
> mention that symbol white list include all symbols in sampled binary,
Done.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66766/new/

https://reviews.llvm.org/D66766