[PATCH] D67004: [DebugInfo] Enable call site parameter debug info for ARM and AArch64

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 12:01:49 PDT 2019


dstenb added inline comments.


================
Comment at: lib/Frontend/CompilerInvocation.cpp:784
+           Arch == llvm::Triple::armeb;
+  };
+
----------------
vsk wrote:
> This helper would be easier to read as an out-of-line function, imo.
Or perhaps something like this?

```
const llvm::Triple::ArchType DebugEntryValueArchs[] = {llvm::Triple::x86, [...]};

llvm::is_contained(DebugEntryValueArchs, Arch)
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67004/new/

https://reviews.llvm.org/D67004





More information about the llvm-commits mailing list