[PATCH] D66993: [ARM][ParallelDSP] SExt mul for accumulation

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 11:34:17 PDT 2019


efriedma added a comment.

Could you describe the complete flow here?  If getAccumulator() returns a value, I think I see how it works; the type of that value is the type of the final accumulator, and you need to sign-extend multiplies to match that type.  If getAccumulator() returns null, I don't see how this is supposed to work; it looks like the code arbitrarily decides the accumulator should be 32 bits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66993/new/

https://reviews.llvm.org/D66993





More information about the llvm-commits mailing list