[PATCH] D66411: Fix -ftime-trace breaking flame-graph assumptions

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 04:13:57 PDT 2019


russell.gallop updated this revision to Diff 218066.
russell.gallop marked an inline comment as done.
russell.gallop edited the summary of this revision.
russell.gallop added a comment.

Realised that this could be done with just an assert (no separate check function) so this is a much smaller patch now. This still mostly hits the assertion with the previous way of calculating duration (duration_cast). I think the extra code in end() may make it slightly less likely that this case happens, but only with assertions enabled.

Please take another look.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66411/new/

https://reviews.llvm.org/D66411

Files:
  llvm/lib/Support/TimeProfiler.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66411.218066.patch
Type: text/x-patch
Size: 4206 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190830/93bd17b0/attachment.bin>


More information about the llvm-commits mailing list