[PATCH] D66992: [ELF] Set `referenced` bit of Undefined created by BitcodeFile

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 218031.
MaskRay edited the summary of this revision.
MaskRay added a comment.

Seems we don't have enough tests.

Add two other cases that the lazy object should be fetched


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66992/new/

https://reviews.llvm.org/D66992

Files:
  ELF/InputFiles.cpp
  test/ELF/lto/Inputs/undef.ll
  test/ELF/lto/undef-weak-lazy.ll


Index: test/ELF/lto/undef-weak-lazy.ll
===================================================================
--- /dev/null
+++ test/ELF/lto/undef-weak-lazy.ll
@@ -0,0 +1,23 @@
+; REQUIRES: x86
+; RUN: llvm-as %S/Inputs/undef.ll -o %tundef.o
+; RUN: llvm-as %s -o %tweakundef.o
+; RUN: llvm-as %S/Inputs/archive-3.ll -o %tdef.o
+
+;; Test that the lazy bitcode %tdef.o is fetched.
+; RUN: ld.lld %tundef.o --start-lib %tdef.o --end-lib -shared -o %t.so
+; RUN: llvm-nm %t.so | FileCheck %s
+
+;; Test %tweakundef.o does not change STB_GLOBAL to STB_WEAK.
+; RUN: ld.lld %tundef.o %tweakundef.o --start-lib %tdef.o --end-lib -shared -o %t.so
+; RUN: llvm-nm %t.so | FileCheck %s
+
+;; %tweakundef.o does not fetch %tdef.o but %tundef.o does.
+; RUN: ld.lld --start-lib %tdef.o --end-lib %tweakundef.o %tundef.o -shared -o %t.so
+; RUN: llvm-nm %t.so | FileCheck %s
+
+; CHECK: T foo
+
+target triple = "x86_64-unknown-linux-gnu"
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+
+declare extern_weak void @foo()
Index: test/ELF/lto/Inputs/undef.ll
===================================================================
--- /dev/null
+++ test/ELF/lto/Inputs/undef.ll
@@ -0,0 +1,4 @@
+target triple = "x86_64-unknown-linux-gnu"
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+
+declare void @foo()
Index: ELF/InputFiles.cpp
===================================================================
--- ELF/InputFiles.cpp
+++ ELF/InputFiles.cpp
@@ -1478,7 +1478,9 @@
     Undefined newSym(&f, name, binding, visibility, type);
     if (canOmitFromDynSym)
       newSym.exportDynamic = false;
-    return symtab->addSymbol(newSym);
+    Symbol *ret = symtab->addSymbol(newSym);
+    ret->referenced = true;
+    return ret;
   }
 
   if (objSym.isCommon())


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66992.218031.patch
Type: text/x-patch
Size: 1767 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190830/c55d6ab9/attachment.bin>