[PATCH] D66909: [GVN] Disallow phi translation for expressions with calls.

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 13:46:29 PDT 2019


wmi added a comment.

Thanks Alina to analyze the problem and write the fix.

I agree with your analysis and I believe the patch could fix the problem. But I am little worried the blunt hammer fix could pontentially hurt performance.  Maybe we can use MD to do a finegrain check? I draft a fix attached. Please take a look whether it is correct and free to change it. F9879631: patch <https://reviews.llvm.org/F9879631>


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66909/new/

https://reviews.llvm.org/D66909





More information about the llvm-commits mailing list