[PATCH] D66820: [06/10] [COFF] Add a ResourceSectionRef method for getting resource contents

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 13:37:16 PDT 2019


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

lgtm, nice.



================
Comment at: llvm/test/tools/llvm-cvtres/combined.test:37
 CHECK-NEXT:          Reserved: 0
+CHECK-NEXT:          Data (
+CHECK:               )
----------------
These `Data (` sections here print data, but since the next line says CHECK instead of CHECK-NEXT we just don't print hit here, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66820/new/

https://reviews.llvm.org/D66820





More information about the llvm-commits mailing list