[PATCH] D66823: [08/10] [WindowsResource] Remove use of global variables in WindowsResourceParser

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Nice!



================
Comment at: llvm/include/llvm/Object/WindowsResource.h:192
 
-    explicit TreeNode(bool IsStringNode);
+    explicit TreeNode(uint32_t StringIndex);
     TreeNode(uint16_t MajorVersion, uint16_t MinorVersion,
----------------
Maybe comment what StringIndex and DataIndex are?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66823/new/

https://reviews.llvm.org/D66823