[PATCH] D66971: TableGen: Remove assert that pattern results match input number

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 12:50:11 PDT 2019


arsenm created this revision.
arsenm added reviewers: dsanders, hfinkel, craig.topper.
Herald added subscribers: jfb, tpr, wdng.

AMDGPU has some atomic instructions that do not return the previous
result, and can only be selected if there are no uses. The source
pattern will only match if the use is empty, so it should be safe to
discard the result.


https://reviews.llvm.org/D66971

Files:
  utils/TableGen/DAGISelMatcherGen.cpp


Index: utils/TableGen/DAGISelMatcherGen.cpp
===================================================================
--- utils/TableGen/DAGISelMatcherGen.cpp
+++ utils/TableGen/DAGISelMatcherGen.cpp
@@ -1047,7 +1047,6 @@
     }
   }
 
-  assert(Ops.size() >= NumSrcResults && "Didn't provide enough results");
   SmallVector<unsigned, 8> Results(Ops);
 
   // Apply result permutation.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66971.217960.patch
Type: text/x-patch
Size: 381 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190829/7db0a682/attachment.bin>


More information about the llvm-commits mailing list